core: added scanning for results #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added tests for float added scan to method renamed decimal functions to be more clear fix lint
Yaiba
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I should've split this up into separate PRs. It does 3 things:
decimalpackage intotypes. It also renames some of the exported functions related to decimals to make it clear that they are for decimals (e.g.NewExplicit->NewDecimalExplicit). Previously, it was clear that these were for decimals because they were in the decimals package, but now that is not the case.decimaltype tonumeric, to make it match Postgres more closely. This was actually a change I made in the new engine a while ago., there were just a few straggling things I hadn't updated.decimalstill works as an alias tonumeric.